Well thank you for finally clearing that up and confirming my suspicions. I can now rest easy knowing the solution is pretty much out of my capabilities cause messing around with the binaries is going to be way more difficult than just downloading a hex editor and using other people's great documentation. I'll leave it to the experts when they get around to it.
In the meantime I've diverted my attention towards playing with the Unks inside waza trying to find anything that sticks. Right now I'm trying to give a thorough testing to Unk12 and in that regard I found this snippet of info on Ultimate Pokemon Center. As a caveat, the author did specify this was for Explorers of Time/Darkness and it's possible Explorers of Sky utilizes something different.
Critical Hits
Attacks can’t be a critical hit if the target has the Lucky Chant status, it has Battle Armor or Shell Armor, or the skill Critical Dodger is enabled for the target.
A variable X is set to the move’s initial critical hit rate. X is then halved if the attacker is male or gender-unknown.
If the attacker has the Focus Energy status, X is set to 999.
If the attacker is holding Scope Lens, or the attacker’s Sharpshooter is enabled, X rises by 15.
If the attacker has Super Luck, X rises by 15.
If the target is holding Patsy Band, X rises by 15.
If the attack is "super effective" and the attacker’s Type-Advantage Master is enabled, X is set to 40.
If a random integer from 0 through 99 is less than X and Teary Cape doesn’t affect the target, the attack is a critical hit and the Damage is doubled if the attacker has Sniper, or multiplied by 1.5 otherwise.
I was curious has to how this info was obtained, but the author's linked github shows numerous different programming projects/tools/utilities and I do recall his name popping up in that huge GameFAQs thread so I don't think it's a stretch to assume some amount of effort and data mining was done. I wanted to see how accurate this was, in particular the line
X is then halved if the attacker is male or gender-unknown.
which just sounds absolutely ridiculous to me that female has two times higher base critical chance than males or unknowns so I set out to test and here were my rather quick results. Forgive the appearance, excel formatting is NOT my strong suit, also SS = The IQ Skill Sharpshooter. No other crit modifiers were included.
Early conclusions to draw:
Unk12 is without a doubt directly related to the critical chance of an ability.
Either there is another component to the base critical chance of each ability, or the entire formula is wrong. Unk12 = ~60 with absolutely no other modifiers is 100% Crit
X/2 if Male or Unknown appears to be completely false, as in fact the data favored males, but much too low sample size to say anything more.
Sharpshooter being X+15 seems to be fairly accurate.
That's all I have for tonight, I'd definitely love to refine the sample sizes and include gender unknown data as well, but I don't want to go overboard because my goal isn't to perfectly fine tune the crit formula, it's only to find out Unk12's role and how it relates to criticals.
Also, psy_commando I hope my posts asking for help or posting my findings aren't derailing this thread's original purpose as your research repository. If they're disruptive to your work I'll be happy to remove them.