PKHeX 21.08.06

45 minutes ago, Mario60866 said:

Firstly, thank you so much for creating PkHex! I really love it, and it's helped a lot with rebuilding an improved but otherwise exact replica of my Pokemon Platinum save file!

I do need help however with making 3ds saves usable with PKhex when transferred to my computer via R4i save dongle. I want to extract various Pokemon data from my Ultra Moon file and take my Crystal Pokemon from my emulator to Ultra Moon (I wish I could have bought real VC Crystal but... Money shortage). Can someone guide me on how to do this? (Please avoid custom 3ds firmware; I cannot risk bricking my 3ds)

It's nearly impossible to brick a 3DS. The process is so refined.

I must report again an error I have reported some time ago: if a roamer on the 5th gen is marked as Defeated or Captured, it is impossible to mark it as Not roamed. The option just doesn't pop up.

4 minutes ago, Lt. Lynx said:

I must report again an error I have reported some time ago: if a roamer on the 5th gen is marked as Defeated or Captured, it is impossible to mark it as Not roamed. The option just doesn't pop up.

Thanks for reporting. Do you have a "before roaming save" and a "after roaming save" that is directly after the before roaming we could use to document it?

14 hours ago, theSLAYER said:

Thanks for reporting. Do you have a "before roaming save" and a "after roaming save" that is directly after the before roaming we could use to document it?

The only save I have has it already captured. However, even with a recently started save, when you mark the roamer as Defeated or Captured and save it, the option for Not roamed disappears.

17 minutes ago, Lt. Lynx said:

The only save I have has it already captured. However, even with a recently started save, when you mark the roamer as Defeated or Captured and save it, the option for Not roamed disappears.

Just to be clear, you're not trying to make it roam before you defeated E4 right?

In your original scenario, E4 was defeated and it was once roaming right?

2 hours ago, theSLAYER said:

Just to be clear, you're not trying to make it roam before you defeated E4 right?

In your original scenario, E4 was defeated and it was once roaming right?

That doesn't matter. Before or after, if one of them is in PkHex selected as Defeated or Captured, the option for Not roaming is not available.

However, in my case, it was already legally captured. I'll show you with some images from a recently started save. It's the same for the save I have.

Not a bug; PKHeX just prevents you from toggling the Captured/Defeated state back to any of the not-presented states because a simple ComboBox does not handle the changes required to set the requested not-roamed or roaming state.

                // CurrentStat:ComboboxSource
                // Not roamed: Not roamed/Defeated/Captured
                //    Roaming: Roaming/Defeated/Captured
                //   Defeated: Defeated/Captured
                //   Captured: Defeated/Captured
                // Top 2 bit acts as flags of some sorts
                for (int i = 0; i < cbr.Length; i++)
                {
                    int c = SAV.Data[ofsRoamer + 0x2E + i];
                    var states = GetStates();
                    if (states.All(z => z.Value != c))
                        states.Add(new ComboItem($"Unknown (0x{c:X2})", c));
                    cbr[i].Items.Clear();
                    cbr[i].InitializeBinding();
                    cbr[i].DataSource = new BindingSource(states.Where(v => v.Value >= 2 || v.Value == c).ToList(), null);

17 hours ago, Kaphotics said:

Not a bug; PKHeX just prevents you from toggling the Captured/Defeated state back to any of the not-presented states because a simple ComboBox does not handle the changes required to set the requested not-roamed or roaming state.

                // CurrentStat:ComboboxSource
                // Not roamed: Not roamed/Defeated/Captured
                //    Roaming: Roaming/Defeated/Captured
                //   Defeated: Defeated/Captured
                //   Captured: Defeated/Captured
                // Top 2 bit acts as flags of some sorts
                for (int i = 0; i < cbr.Length; i++)
                {
                    int c = SAV.Data[ofsRoamer + 0x2E + i];
                    var states = GetStates();
                    if (states.All(z => z.Value != c))
                        states.Add(new ComboItem($"Unknown (0x{c:X2})", c));
                    cbr[i].Items.Clear();
                    cbr[i].InitializeBinding();
                    cbr[i].DataSource = new BindingSource(states.Where(v => v.Value >= 2 || v.Value == c).ToList(), null);

 

Then, how could I set it as Not roamed or Roaming? That would be an interesting option.

3 hours ago, Lt. Lynx said:

Then, how could I set it as Not roamed or Roaming? That would be an interesting option.

By researching the changes required to the save file to get the state you want, documenting them, and implementing them into the program? PKHeX is not magic.

59 minutes ago, Kaphotics said:

By researching the changes required to the save file to get the state you want, documenting them, and implementing them into the program? PKHeX is not magic.

I don't have enough knowledge to do that, but I have helped a pair of times with another researches. Could I help with this in any way?

Hey there, I have been working with Ruby (2002), when I check the "is egg" box, the nickname is displayed in japanese regardless of the language I pick. This doesn't happen with other games (e.g. moon or sword). So I get an error when the system checks if it's legit or not. Am I missing something? Could you take a look? Thanks!

4 hours ago, Hide said:

Hey there, I have been working with Ruby (2002), when I check the "is egg" box, the nickname is displayed in japanese regardless of the language I pick. This doesn't happen with other games (e.g. moon or sword). So I get an error when the system checks if it's legit or not. Am I missing something? Could you take a look? Thanks!

Yes that is how the game stores the eggs, with the nickname as Japanese, even if it doesn't show in-game. However, PKHeX won't push an error associated to that. Not sure what you did wrong here.

I get the error if the egg's OT data is in english. My workaround was changing the name of the OT to Japanese.
Since it's an egg there shouln't be issues with the game, but PKHEX considers it's an error otherwise "OT name is too short".

7 minutes ago, Hide said:

I get the error if the egg's OT data is in english. My workaround was changing the name of the OT to Japanese.
Since it's an egg there shouln't be issues with the game, but PKHEX considers it's an error otherwise "OT name is too short".

mind uploading the file for me to take a look?

Sure! Here it is.

246 - タマゴ - E371546CE61A.pk3

21 minutes ago, Hide said:

Sure! Here it is.

246 - タマゴ - E371546CE61A.pk3 100 B · 0 downloads

So I just did a test on some random's game:

The original OT still exists. Oddly your file doesn't have an OT.

Was the OT removed? What was the OT of the save that received the egg?
 

Thanks! I noticed you applied “my workaround”.

So, Pokémon eggs (GEN III) must be encoded as Japanese region Pokémon regardless of the sav file region. Since I was not aware of this detail, I had the impression this was some sort of bug.

Then the """issue""" (not a real issue) is that Pokémon eggs are encoded with Asian characters; PKHex updates the OT name with the name in your sav file and if you load an English sav file, the OT name displays with non-Asian characters (e.g. NEKO instead of ＮＥＫＯ) and this returns the legality check issue.

If Pokémon eggs must be Japanese, it would be good to automatically switch the region of the Pokémon to JPN after checking the “is egg” box, just like the name is automatically changed to タマゴ (tamago, egg in Japanese).

An ideal addition would be automatically transposing the OT name from english to asian encoding (e.g. “A” to “Ａ”) when checking the “is egg” box. Alternatively, we could have the error message changed from “OT name is too short” to “OT name should be in ＡＳＩＡＮ text encoding”.

48 minutes ago, Hide said:

Thanks! I noticed you applied “my workaround”.

So, Pokémon eggs (GEN III) must be encoded as Japanese region Pokémon regardless of the sav file region. Since I was not aware of this detail, I had the impression this was some sort of bug.

Then the """issue""" (not a real issue) is that Pokémon eggs are encoded with Asian characters; PKHex updates the OT name with the name in your sav file and if you load an English sav file, the OT name displays with non-Asian characters (e.g. NEKO instead of ＮＥＫＯ) and this returns the legality check issue.

If Pokémon eggs must be Japanese, it would be good to automatically switch the region of the Pokémon to JPN after checking the “is egg” box, just like the name is automatically changed to タマゴ (tamago, egg in Japanese).

An ideal addition would be automatically transposing the OT name from english to asian encoding (e.g. “A” to “Ａ”) when checking the “is egg” box. Alternatively, we could have the error message changed from “OT name is too short” to “OT name should be in ＡＳＩＡＮ text encoding”.

done https://github.com/kwsch/PKHeX/commit/640cb3bad10c568462071adf236fd73e26531b99

1 hour ago, Hide said:

Thanks! I noticed you applied “my workaround”.

So, Pokémon eggs (GEN III) must be encoded as Japanese region Pokémon regardless of the sav file region. Since I was not aware of this detail, I had the impression this was some sort of bug.

Then the """issue""" (not a real issue) is that Pokémon eggs are encoded with Asian characters; PKHex updates the OT name with the name in your sav file and if you load an English sav file, the OT name displays with non-Asian characters (e.g. NEKO instead of ＮＥＫＯ) and this returns the legality check issue.

If Pokémon eggs must be Japanese, it would be good to automatically switch the region of the Pokémon to JPN after checking the “is egg” box, just like the name is automatically changed to タマゴ (tamago, egg in Japanese).

An ideal addition would be automatically transposing the OT name from english to asian encoding (e.g. “A” to “Ａ”) when checking the “is egg” box. Alternatively, we could have the error message changed from “OT name is too short” to “OT name should be in ＡＳＩＡＮ text encoding”.

Just a reminder to readers: this applies to Gen 3. The encoding/characters format changes in other generations.

I didn't apply your workaround. My egg is an egg I received in-game on an ENG save, free from modifications.

Relating to your "Asian encoding" statement, what you see is just a quirk with the Gen 3 encoding, or maybe I should say it is a quirk with eggs for how PKHeX chooses to display them.

The encoding table for Roman characters between both International and Japanese games are the same. It is just that PKHeX parses them differently based on the language selected on the Pokemon file.


They are not actually encoded as "Asian" characters by themselves. The way they appear changes based on language byte.
(remember, Eggs in Gen 3 games come with JPN set as the language byte)

My Egg examples:

In-game caught Pokemon:


Notice how despite they appear different, the bytes are actually the same?

The issue here is with your OT name.
Why does it start with a terminator?


There's data after the terminator, implying there other characters.
(Characters U, T and R)

So let me ask again.
Was the OT removed? What was the OT of the save that received the egg? :3

I'm curious. Did you delete the name? Maybe it bore other characters and PKHeX yeeted them? Maybe the other OT characters don't go into an egg before it hatches? Need to know what is your OT name, and whether this egg was modified before extraction. Perhaps provide your save so I can take a look.

13 hours ago, theSLAYER said:

The original OT still exists. Oddly your file doesn't have an OT.
Was the OT removed? What was the OT of the save that received the egg?
 

No, I put an "english encoded" name (it was NEKO) but it did not save with the file. The name from my sav was Sutr, but since it had said issues I changed it to NEKO (but it seems the name was deleted after I saved the file).

1 minute ago, Hide said:

No, I put an "english encoded" name (it was NEKO) but it did not save with the file.

Was the egg's OT name originally blank? Did you make this egg from scratch or received it in-game?

Writing an OT to the egg in current stable PKHeX doesn't stick. I had to modify the pk3 with Hex editor for the egg to show up legal.



I wrote the line into PK3 via hex editor

3 hours ago, Kaphotics said:

done https://github.com/kwsch/PKHeX/commit/640cb3bad10c568462071adf236fd73e26531b99

That's very nice!

2 hours ago, theSLAYER said:

The way they appear changes based on language byte (...)
Writing an OT to the egg in current stable PKHeX doesn't stick. (...)

Yes, so regarding the comparison between ＳＡＲＡ and SARA, perhaps what we see in the picture is the value that addresses the character in the font map.

So, hypothetically speaking, a full-width “Ｓ” stands as FF in the Japanese character map.
And the regular “S” stands as FF in the English character map.
However, if you enter a regular “S” in the Japanese character map, it doesn’t stick because it’s different than the fullwidth character “Ｓ”.

When you change the PKM region to JPN, an OT name in “fullwidth text”* is expected; if you enter a name with the “standard text” you get an error. The error being “name is to short”.

I can switch my keyboard input in the computer, so then I edited the OT “writing in Japanese” (that was my workaround). I did not have to change the name with the hex editor.

So, the name sticks if you employ (for example) Japanese input, this is why I suggested updating the error message from “name is to short” to “use asian encoding”. When I entered the name using fullwidth characters the error was gone, it also was gone when you hex-edited the file because you assigned the correct Ｓ “via code”.

BTW, I didn’t know the OT name wasn’t there until you asked for the OT name. I did not delete it, I saved the PKM egg using standard characters so you could see “the bug”. Interestingly, I changed the name to “Neko” but the file was saved with data from my sav file (hence the “utr” characters you pointed before).

*(which I have been calling “Asian text” or “Asian encoded text”).

Thank you both for the great replies.

2 hours ago, Hide said:

BTW, I didn’t know the OT name wasn’t there until you asked for the OT name. I did not delete it, I saved the PKM egg using standard characters so you could see “the bug”. Interestingly, I changed the name to “Neko” but the file was saved with data from my sav file (hence the “utr” characters you pointed before).

Yeah the OT name was missing. I'm wondering if it is a remnant from you trying to change the OT name or something.

Just now, theSLAYER said:

Yeah the OT name was missing. I'm wondering if it is a remnant from you trying to change the OT name or something.

Yeah, its a fun thing it took the data from the OT in english.

when will the next update come?
because there are some pokemon that cannot be legalized in pkhex, such as the Papa Zarude now.

Or do you want to wait with the new update for Brillant Diamond and Shining Pearl?