[Bug] Event Golduck name not matching species

[theSLAYER]

User @Omnipotent Arceus informed me that there's an issue with how PKHeX handles this particular event.

While it was distributed with language byte set to Japanese, it isn't nicknamed,
hence it's name would be default, based on receiving language.

Now, enter the problem:

[Kaphotics]

If the language ID is fixed to Japanese, it should have the Japanese default name, no? Are there previous language locked wondercards that exhibit this behavior?

Are you referring to the wc*->pk* process, or the legality checking not allowing this nickname case?

[Sabresite]

IIRC there is a bug where the name is set without considering the language tag.

[theSLAYER]

IIRC the game basically ignores the language tag, and generates the name based on the game save's language, when no nickname is defined in the wonder card.

(The game won't specifically gen a different name based on language tag. It's solely dependent on game save language. I think this behavior has been around since Gen 4; think of it as the same thing as evolving a traded Pokemon, where the name assigned isn't based on language tag.)

The user above basically injected the wonder card into a CHS language save, then redeemed it in game.

As for whether any past events display this behavior, I'll need to check, but from my memory past events that had language tags ALSO had nickname, hence why this issue hasn't popped up until now.

 

edit: I'm referring to legality check not allowing that default name + language tag combo, when it's possible to redeem it as such.

[Kaphotics]

Cool, exclusion added:

https://github.com/kwsch/PKHeX/commit/ebae14e6ad476cef85610373a314d527edd13972

Thanks for reporting

[theSLAYER]

11 hours ago, Kaphotics said:

Cool, exclusion added:

https://github.com/kwsch/PKHeX/commit/ebae14e6ad476cef85610373a314d527edd13972

Thanks for reporting

Thanks for your hard work!
 

(also, nice comment >< )

Quote

// fixed language without nickname, nice job event maker!

 

[ICanSnake]

The latest commit fixes 05146 ScreenPeekaz Machamp too, right? That's the other event with a language locked tag.

[theSLAYER]

@Kaphotics I'm still search for other Pokemon based on existing trainers, as those events fit the bill.
another example is Ray's Metagross, if I'm not mistaken.

Edit:
I just tested and confirmed on my end that the effect I explained earlier exists in Gen 5.
Ray Rizzo's Metagross gained a Korean name despite having language tagged to ENG.

25 minutes ago, ICanSnake said:

The latest commit fixes 05146 ScreenPeekaz Machamp too, right? That's the other event with a language locked tag.

Looking at the PKHeX code, it looks like it does

[Kaphotics]

Should be fixed on latest commit

https://github.com/kwsch/PKHeX/commit/1fe304e78f6578c32f5b4d782ca3022e6ec23225