BLACKBIRD Posted April 5, 2018 Share Posted April 5, 2018 (edited) I want to edit VC Gold(Korean) However, only 'seen' was applied, and 'caught' was not applied. The same results were obtained for the three cases. What mistake did I make?(I used JKSM) Edited April 5, 2018 by BLACKBIRD Link to comment Share on other sites More sharing options...
theSLAYER Posted April 5, 2018 Share Posted April 5, 2018 @Kaphotics I was able to replicate this. The "Seen All" doesn't seem to change the Seen Pokemon (and didn't affect the caught Pokemon; checked in case it was swapped), and the "Caught All" made all the Pokemon appear seen, not caught. 1 Link to comment Share on other sites More sharing options...
Kaphotics Posted April 5, 2018 Share Posted April 5, 2018 https://github.com/kwsch/PKHeX/blob/8710c7a5179d4488f95d2397a2bc34089fa97e8d/PKHeX.Core/Saves/Substructures/SAV2Offsets.cs#L165-L166 appears to be Caught first then Seen (offset-wise). Does it apply to all other gen2 versions? (should it be Seen then Caught?) or is it just the GUI screwing up? Link to comment Share on other sites More sharing options...
theSLAYER Posted April 5, 2018 Share Posted April 5, 2018 12 minutes ago, Kaphotics said: https://github.com/kwsch/PKHeX/blob/8710c7a5179d4488f95d2397a2bc34089fa97e8d/PKHeX.Core/Saves/Substructures/SAV2Offsets.cs#L165-L166 appears to be Caught first then Seen (offset-wise). Does it apply to all other gen2 versions? (should it be Seen then Caught?) or is it just the GUI screwing up? I can confirm that "Seen" and "Caught" works correctly on ENG and JPN versions of Pokemon Crystal, As well as Japanese Pokemon Gold. BTW for the Korean versions, having "Caught All" and "Seen All" all checked, doesn't show the Pokedex as complete (only shows all as seen), so I don't think it was swapped; the "Caught" offset might be different. Link to comment Share on other sites More sharing options...
BLACKBIRD Posted April 5, 2018 Author Share Posted April 5, 2018 I think 'seen' and 'caught' seem to work incorrectly in the GS (Korean) version. The results for 'Gold version' and 'Silver version' were the same. Link to comment Share on other sites More sharing options...
Kaphotics Posted April 6, 2018 Share Posted April 6, 2018 Thanks, fixed in latest commit; just some misaligned offsets. https://github.com/kwsch/PKHeX/commit/1122a3f21edfb02cd6506ee1afde117b518d9c19 1 Link to comment Share on other sites More sharing options...
BLACKBIRD Posted April 6, 2018 Author Share Posted April 6, 2018 Thanks, @Kaphotics @theSLAYER Can I use the latest fixed version now? or should I wait for the official release? Link to comment Share on other sites More sharing options...
Sabresite Posted April 6, 2018 Share Posted April 6, 2018 9 hours ago, BLACKBIRD said: Thanks, @Kaphotics @theSLAYER Can I use the latest fixed version now? or should I wait for the official release? I think you need to compile it yourself. Or wait for the next release. Link to comment Share on other sites More sharing options...
BLACKBIRD Posted April 7, 2018 Author Share Posted April 7, 2018 3 hours ago, Sabresite said: I think you need to compile it yourself. Or wait for the next release. Ill wait, because I dont know about the computer language Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now