Kaphotics Posted November 29, 2017 Posted November 29, 2017 The current Frame RNG detection is still a work in progress; Unown currently doesn't work (as it doesn't have encounter slots defined). https://github.com/kwsch/PKHeX/blob/fa78154df780a384bedb8194fdb522a8b91ce3f5/PKHeX.Core/Legality/Encounters/Data/Encounters3.cs#L316-L381 Will need to figure out how the game generates frames / slots for Unown first . The game code does something similar to the Nature/Gender waiting, but instead for Form/Nature. https://github.com/pret/pokeruby/blob/5498eaf94849bbc7b56d8c280862b61ecefa0643/src/pokemon/pokemon_1.c#L192-L208 Will need to have a special frame generator in this case!
Sabresite Posted November 29, 2017 Posted November 29, 2017 If I remember correctly, for gen 3, Unown is ABDE. Not sure if C is a waste call or not.
Kaphotics Posted November 29, 2017 Posted November 29, 2017 @Sabresite the unown frame generation isn't implemented (pid swapped calls plus the wait for nature and altform). The BACE/BADE etc split is due to vblank interrupts in between generation of the pkm; setting individual fields does a complete decrypt-setval-encrypt which is relatively slow when setting multiple fields during pkm generation. They didn't introduce a fast mode setting until later generations (sanity flags)
Sabresite Posted November 29, 2017 Posted November 29, 2017 2 hours ago, Kaphotics said: @Sabresite the unown frame generation isn't implemented (pid swapped calls plus the wait for nature and altform). The BACE/BADE etc split is due to vblank interrupts in between generation of the pkm; setting individual fields does a complete decrypt-setval-encrypt which is relatively slow when setting multiple fields during pkm generation. They didn't introduce a fast mode setting until later generations (sanity flags) Oh yeah, I forgot they swapped the PID from AB to BA. Which is interesting because the pokeruby you linked to shows Random32 call, which is the normal wild mon, not swapped (like event pokes).
Kaphotics Posted November 29, 2017 Posted November 29, 2017 42 minutes ago, Sabresite said: Oh yeah, I forgot they swapped the PID from AB to BA. Which is interesting because the pokeruby you linked to shows Random32 call, which is the normal wild mon, not swapped (like event pokes). Pokeruby isnt pokefirered There's no similarly progressed disassembly project for frlg
Sabresite Posted November 30, 2017 Posted November 30, 2017 2 hours ago, Kaphotics said: Pokeruby isnt pokefirered There's no similarly progressed disassembly project for frlg Oh that is right, unown was not available in RS. What is that gender/nature/letter generation function used for? I don't see it referenced anywhere in the game itself. Is it leftovers?
Kaphotics Posted November 30, 2017 Posted November 30, 2017 It has a single use in emerald for Cute Charm (await gender): https://github.com/pret/pokeemerald/search?utf8=✓&q=CreateMonWithGenderNatureLetter&type= AltForm is hardcoded to 0 in that call, so it's never used for the await forme case. I assume that it'd be used correctly for gen3 FRLG Tanoby Ruins Unown
Kaphotics Posted November 30, 2017 Posted November 30, 2017 Implemented in latest commit https://github.com/kwsch/PKHeX/commit/36894a588d67263616e1db858a15e35ff11134a6 1
manolin18 Posted November 30, 2017 Posted November 30, 2017 14 hours ago, Davil said: A questionWhat program does that do?Thank you
Kaphotics Posted November 30, 2017 Posted November 30, 2017 PKHeX does that. Hold control to see the complete parse; it's not shown normally (most often just has debug info and valid check result entries).
manolin18 Posted November 30, 2017 Posted November 30, 2017 11 hours ago, Kaphotics said: PKHeX does that. Hold control to see the complete parse; it's not shown normally (most often just has debug info and valid check result entries). Thank you very much!!!I had seen it many times but I had never asked how to do it
Davil Posted December 2, 2017 Author Posted December 2, 2017 On 2017/11/30 at 12:42 AM, Kaphotics said: The current Frame RNG detection is still a work in progress; Unown currently doesn't work (as it doesn't have encounter slots defined). https://github.com/kwsch/PKHeX/blob/fa78154df780a384bedb8194fdb522a8b91ce3f5/PKHeX.Core/Legality/Encounters/Data/Encounters3.cs#L316-L381 Will need to figure out how the game generates frames / slots for Unown first . The game code does something similar to the Nature/Gender waiting, but instead for Form/Nature. https://github.com/pret/pokeruby/blob/5498eaf94849bbc7b56d8c280862b61ecefa0643/src/pokemon/pokemon_1.c#L192-L208 Will need to have a special frame generator in this case! On 2017/11/29 at 9:48 PM, Davil said: 201-01 - アンノーン - B7A9E4B4784D.pk7 In Gen7 met level 100 : invalid met level 25 : legal Why??
Kaphotics Posted December 2, 2017 Posted December 2, 2017 was fixed earlier today https://github.com/kwsch/PKHeX/commit/1fcac7c06b580a42e7c240bbcbae1bd51509c7b1 it's still a work in progress
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now