[Bug?] Pokémon originated from Gen 1 with Gen 2 Egg Moves are marked as legal

[mg1189]

Hello,

when I edited my Gen 7 Save file to insert some Pokémon originated from Gen 1, I noticed that PKHeX incorrectly considers it as legal, when it has an Egg move introduced in Gen 2.

Example:
Charizard with the Moves:
- Belly Drum (can only be bred on Charmander, introduced in Gen 2)
- Submission (TM in Gen 1 only)

Egg moves introduced in Gen 3 and later (e.g. Dragon Dance) are correctly marked as illegal.

I'm using the latest Build (#3883) on Windows 10. The example Charizard is attached to this post. It did not pass the hack check, when I tried to trade it online in Sun/Moon.

006 - Charizard - 9E2560751D17.pk7

[Kaphotics]

VC games can trade from GS to RBY then can be imported to Gen7. Version for VC pkm is whichever game transferred it, as that value isn't stored in gen1/2 format.

PKHeX detects your Charizard as being originated from an egg, as it's the only way the move is legal.

[Ruby Genseki]

19 minutes ago, Kaphotics said:

PKHeX detects your Charizard as being originated from an egg, as it's the only way the move is legal.

I was gonna comment the same sort of thing a while ago, but then I thought there was no way for the Charizard to be hatched in gen 2 and then sent to gen 1 while keeping Belly Drum, since the move itself doesn't exist at all in said gen. In other words, it still shouldn't be able to know both moves unless I'm missing something.

[Kaphotics]

Fixed, thanks for reporting!

https://github.com/kwsch/PKHeX/commit/4d91aad8765758e6cd6992444da4e5c89280bf78