Bug reporting: Nickname of Gen I / II (JPN)

[smileynation]

I am always grateful for your help.
Japanese "エ (E)" is displayed as a nickname, it will be converted to "ェ (e)".

It will also occur in the updated version today.

 

example: 

エンテイ →ェンテイ

 

[Kaphotics]

Thanks, fixed in latest commit!

https://github.com/kwsch/PKHeX/commit/b201ded8e86f788a2b9059cb0fccf7635963274c

For user ease, PKHeX maps both the uppercase and lowercase characters to the same value even though only one naturally exists in the character encoding table.

There are other cases of this, as listed in the commit message. Flipped it to map back to the uppercase character not the lowercase.

[theSLAYER]

35 minutes ago, Kaphotics said:

even though only one naturally exists in the character encoding table.

Regarding this,
Actually Gen II VC allows nickname input of the small characters for ァ ィ ゥ ェ ォ
(IIRC small characters for ゃ ゅ ょ  ャ ュ ョ  also already exists in Gen 1 nickname usage, but I tested it again too.)

Here's an example of Metapod caught and nicknamed in Gen 2, traded to Gen 1, then Poketransported up.
 

and confirmation that its supports big and small characters:

 

 

 

Since we are on the topic of encoding,  English ! and ? from Gen 2 can be imported into SM,
but !? from Japan games get ignored (at present).

Lastly, Korean Gen 2 trade >English Gen 2 > English Gen 1 is supported by VC,
however poketransporter ignores korean characters upon transfer. (at present)

 

[Kaphotics]

1->7 uses a special encoding table, I assume it will be updated when transporter is updated to support 2->7

(see jp_table and us_table in StringConverter.cs)

https://github.com/kwsch/PKHeX/blob/e6f43ff629b83f25ae3e514f0d3f931c773a06e0/PKHeX.Core/PKM/StringConverter.cs#L584-L591

basically an array of 'transferred' characters that is accessed by the gen1 encoding value.

 

Anyway, added 6 more jpn gen2 characters to the encoding table

https://github.com/kwsch/PKHeX/commit/e6f43ff629b83f25ae3e514f0d3f931c773a06e0

no legality checks right now to check for characters not selectable for gen1; could be useful in weeding out gen1 origin encounters

(pls lmk if there's any missing chars for the lookup table, I think I got them all?)

[theSLAYER]

I think all of English and Japanese is covered.

However, German versions have a few extra (I didn't see these in the file):
Ä Ö Ü ä ö ü

and international versions also has the multiplication symbol ×(not x) :

(maybe it is {0x9B, "\\"} ; there's no note on what this is, and it doesn't exist, so maybe you had it covered)