Well, I was working on my own PID/IVs tool, and found out some issues. In order to reproduce them, you can get a Pal Parked Pikachu and a Shinx off pkmndb.com, and then change their PID and IVs each time with the following values (an initial seed of 0x0 was used):
1. A-B-C-D
-----------
0000 6073
E97E 7B6A
5271 3895
31B0 DDE4
PID: 0xE97E0000 (3917348864)
IVs: 0x18D85271 (17,19,20,16,13,12)
Legality Checker output:
While Shinx looks fine, Pikachu got 2 types, which is indeed misleading. The right type is actually the second one, anyway.
2. A-B-C-E
-----------
0000 6073
E97E 7B6A
5271 3895
31B0 DDE4
8E42 5287
PID: 0xE97E0000 (3917348864)
IVs: 0x7215271 (17,19,20,2,18,3)
Legality Checker output:
Once again, Pikachu has 2 types. The second one is the good one. Shinx, as expected, appears as hacked/unknown.
3. A-B-C-F
-----------
0000 6073
E97E 7B6A
5271 3895
31B0 DDE4
8E42 5287
E2CC A5EE
PID: 0xE97E0000 (3917348864)
IVs: 0x31665271 (17,19,20,12,22,24)
Legality Checker output:
Nothing much to say here, everything looks okay.
4. A-B-D-E
-----------
0000 6073
E97E 7B6A
5271 3895
31B0 DDE4
8E42 5287
PID: 0xE97E0000 (3917348864)
IVs: 0x72131B0 (16,13,12,2,18,3)
Legality Checker output:
Once again, Pikachu has two types, the 2nd one being the actual one. Shinx looks okay.
5. A-B-D-F
-----------
0000 6073
E97E 7B6A
5271 3895
31B0 DDE4
8E42 5287
E2CC A5EE
PID: 0xE97E0000 (3917348864)
IVs: 0x316631B0 (16,13,12,12,22,24)
Legality Checker output:
Everything's okay this time.
6. A-B-E-F
-----------
0000 6073
E97E 7B6A
5271 3895
31B0 DDE4
8E42 5287
E2CC A5EE
PID: 0xE97E0000 (3917348864)
IVs: 0x31660E42 (2,18,3,12,22,24)
Legality Checker output:
Pikachu and Shinx appear just as expected.
7. A-C-D-E
-----------
0000 6073
E97E 7B6A
5271 3895
31B0 DDE4
8E42 5287
PID: 0x52710000 (1383137280)
IVs: 0x72131B0 (16,13,12,2,18,3)
Legality Checker output:
Pikachu = 2 types, Shinx = okay.
8. A-C-D-F
-----------
0000 6073
E97E 7B6A
5271 3895
31B0 DDE4
8E42 5287
E2CC A5EE
PID: 0x52710000 (1383137280)
IVs: 0x316631B0 (16,13,12,12,22,24)
Legality Checker output:
Pikachu = okay, Shiny = okay.
9. A-D-E-F
-----------
0000 6073
E97E 7B6A
5271 3895
31B0 DDE4
8E42 5287
E2CC A5EE
PID: 0x31B00000 (833617920)
IVs: 0x31660E42 (2,18,3,12,22,24)
Legality Checker output:
Pikachu = okay, Shinx = okay.
10. B-A-C-D
-----------
0000 6073
E97E 7B6A
5271 3895
31B0 DDE4
PID: 0xE97E (59774)
IVs: 0x18D85271 (17,19,20,16,13,12)
Legality Checker output:
Even if Pikachu passed all checks, it is not a GBA event, so it shouldn't appear like that. As for Shinx... well, it cannot be a GBA event, obviously.
Did I miss some GBA methods? Also, regarding the GBA Event, Restricted vs. Unrestricted... how would the Legality Checker know the right one? As far as I know, the difference between the two is that Restricted's seed is limited to 16 bits rather than 32 bits, thus ranging from 0x0 to 0xFFFF. However, the same range could also fall in a Unrestricted type, even if there are pretty low probabilities. According to my tests, the program will just consider anything higher than 0xFFFF as Unrestricted. I would have gladly checked myself, but there's no source code publicy available (and the binary file it's obfuscated too).
