[BUG] Manaphy Egg shown illegal / wrong Egg met date if I import directly the pgt

[AlamosIT]

Hello, today I noticed two little bugs about Manaphy Egg.

I used a real Pokémon Ranger game to send the Manaphy Egg via Rangernet (with real hardware) into a Pokémon Diamond cartdridge. I made different backups before and after receiving the Gift from the postman in the Pokémon Market.

1) The Manaphy Egg received is shown illegal in PKHeX, but, after hatching it, the newborn Manaphy became legal.

490 - Uovo - 1A26464EBFD5.pk4

  

2) Then I tried to import the .pgt file (previously extracted) directly into Box. Here I noticed that the Met Date and Date in Egg Met Condition are inverted. It should be today's date in Egg Met Conditions and a "placeholder" date (01/01/2000) in Met Date, until the Egg is hatched (like in the original Egg shown in the other picture I attached).

   

These aren't very big problems, but I thought it was better to report them

Edited September 5, 2020 by AlamosIT

[Kaphotics]

Thanks, resolved in latest commit. Should generate fine now; other refactorings made the first part show up as legal.

https://github.com/kwsch/PKHeX/commit/39e5c9000d3992a2d52bd333d73771644cfb09d7

[AlamosIT]

7 minutes ago, Kaphotics said:

Thanks, resolved in latest commit. Should generate fine now; other refactorings made the first part show up as legal.

https://github.com/kwsch/PKHeX/commit/39e5c9000d3992a2d52bd333d73771644cfb09d7

Always the best ❤

[AlamosIT]

@Kaphotics sorry for disturbing again, but yesterday I forgot another little related bug.

If I take the Manaphy Egg from the postman, the language is the same as the game. But when importing pgt file into Boxes it is automatically set in English, even if both save file, from IV gen game and Pokémon Ranger, are in another language (Italian in this case).

   

NA - Raw Gift (Uovo di Manaphy PR1).pgt

[Kaphotics]

It was hardcoded for Diamond & English; latest commit now uses the trainer version & language if they're gen4 games (not KOR)

https://github.com/kwsch/PKHeX/commit/187ed9775a5827770e2c429662a6b9573b22c74c

[AlamosIT]

15 hours ago, Kaphotics said:

It was hardcoded for Diamond & English; latest commit now uses the trainer version & language if they're gen4 games (not KOR)

https://github.com/kwsch/PKHeX/commit/187ed9775a5827770e2c429662a6b9573b22c74c

Thank you for your hard work ❤