Multiple exceptions when selecting gen 3 blank saves

[BlackShark]

First of all many thanks for all the new features and fixes that were added over the past months!

So, I tried the recently added blank save selection. So far it works good, but selecting any gen 3 save file will bring up the FRLG version selection window. When you select either FR or LG PKHeX starts throwing multiple exception. Starting with the following

Spoiler

Exception Details:
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at PKHeX.Core.SAV3.IsPKMPresent(Int32 Offset)
at PKHeX.WinForms.Controls.SAVEditor.GetSlotFiller(Int32 offset, PictureBox pb)
at PKHeX.WinForms.Controls.SAVEditor.ResetParty()
at PKHeX.WinForms.Controls.SAVEditor.ResetNonBoxSlots()
at PKHeX.WinForms.Controls.SAVEditor.SetPKMBoxes()
at PKHeX.WinForms.Controls.SAVEditor.ToggleInterface()
at PKHeX.WinForms.Main.ResetSAVPKMEditors(SaveFile sav)
at PKHeX.WinForms.Main.OpenSAV(SaveFile sav, String path)
at PKHeX.WinForms.Main.FormLoadInitialFiles(String[] args)

Loaded Assemblies:
--------------------
mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\Windows\Microsoft.NET\Framework\v4.0.30319\mscorlib.dll

PKHeX, Version=19.1.14.0, Culture=neutral, PublicKeyToken=null
D:\...\PKHeX.exe

System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System\v4.0_4.0.0.0__b77a5c561934e089\System.dll

System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Windows.Forms\v4.0_4.0.0.0__b77a5c561934e089\System.Windows.Forms.dll

System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Drawing\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Drawing.dll

PKHeX.Core, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
D:\...\PKHeX.Core.dll

System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Configuration\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Configuration.dll

System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Core\v4.0_4.0.0.0__b77a5c561934e089\System.Core.dll

System.Xml, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Xml\v4.0_4.0.0.0__b77a5c561934e089\System.Xml.dll

Accessibility, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\Accessibility\v4.0_4.0.0.0__b03f5f7f11d50a3a\Accessibility.dll

System.Windows.Forms.resources, Version=4.0.0.0, Culture=de, PublicKeyToken=b77a5c561934e089
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Windows.Forms.resources\v4.0_4.0.0.0_de_b77a5c561934e089\System.Windows.Forms.resources.dll

--------------------
User Message:
An error occurred while attempting to auto-load your save file.

 

 

And while I'm already talking about it, just a minor suggestion:

Currently there are 2 windows popping up when opening FRLG saves. First an alert telling you that such a save was detected and next the actual selection window. I'm ok with how it currently is, but can't they be merged into a single window by putting the text from the alert window above the dropdown of the selection window?

Thanks for reading

[Kaphotics]

done:

Update blank sav3 behavior:

https://github.com/kwsch/PKHeX/commit/53b2ca93b8fb4685d51c0392a0ce70a7bf8c0516

Merge game selection alert & prompt to 1 popup

https://github.com/kwsch/PKHeX/commit/9fd6d86b1dfbbcaa9c7cbe2c1ff623457c079eb4