BUG: Cute Charm + Swarming = Illegal?

[theSLAYER]

@Kaphotics By chance, I encountered a swarmer while looking for other Pokemon, while my cute charm abuser was in the lead.

104 ★ - CUBONE - ABE400000004.pk4

[Kaphotics]

Logic is currently coded to disallow swarm and cute charm... refer to commit 7b1812f. Refer to comments. Not sure if just ignoring it and returning true is okay... It's from pull request 1314 which references bulbapedia

[theSLAYER]

3 hours ago, Kaphotics said:

Logic is currently coded to disallow swarm and cute charm... refer to commit 7b1812f. Refer to comments. Not sure if just ignoring it and returning true is okay... It's from pull request 1314 which references bulbapedia

Maybe it doesn't make the encounter chance higher, but does affect the gender it encounters?

I've encountered more than one shiny Cubone (on platinum), so pretty sure Cute Charm shiny abuse works on it

edit: (just tagging this here, so that I can find it again)

edit 2: Today's swarm is Larvitar:

Spoiler

246 - LARVITAR - 2AC20000000E.pk4 

246 ★ - LARVITAR - E4CF00000002.pk4

Both shiny and non-shiny was flagged illegal, as both PIDs affected by cute charm.

Need me to test other Gen 4 games, to be sure?

[Kaphotics]

Could be just misinterpretation of "This does not affect a swarming Pokémon species"; emphasis on last word.

Removed the restriction: https://github.com/kwsch/PKHeX/commit/734edfae203fd681c0ea5e67256d916e23295f0c

Thanks for reporting