bug Wrong detection of shiny locked Pokémons

[Asia81]

Hi.

I have my Rayquaza from AS' story.

It is legal, so no soucis.

But if I turn it shiny, PKHeX say "Invalid Encounter" and not something like the pokémon is shiny locked.

The encounter was good.

[Kaphotics]

If it is impossible to encounter a Shiny Rayquaza => it's an invalid encounter (no encounters match).

I've altered the code to defer that shiny check from the encounter matching logic to the EC/PID check, which will now say if it is shiny locked.

There's currently an overhaul of the program in progress, so I'm not pushing a commit of this change until the overhaul is done

[Kaphotics]

Implemented during the code overhaul.

https://github.com/kwsch/PKHeX/blame/6378eb7f561b4dce3c5f79e0f63df717973a7884/Legality/Checks.cs#L40-L46