[BUG] Met Location

[Davil]

Melemele (Akala)  --->  Melemele    194

--------------             --->  Akala           195

Ula’ula (Poni)        --->  Ula’ula         196

--------------             --->  Poni             197

[Kaphotics]

The odd-# location IDs don't exist naturally in-game. They serve as a sub-location identifier; PKHeX combines the two to yield the most accurate location.

[Davil]

58 minutes ago, Kaphotics said:

The odd-# location IDs don't exist naturally in-game. They serve as a sub-location identifier; PKHeX combines the two to yield the most accurate location.

as egg pokemon met location "Melemele (Akala)" is legal......

[Kaphotics]

So those two (well, 4) met locations are not legally obtainable?

internal static readonly HashSet<int> ValidMet_USUM = new HashSet<int>(ValidMet_SM)
{
    194, 196, 198,
    200, 202, 204, 206, 208, 210, 212, 214, 216, 218, 220, 222, 224, 226, 228, 230, 232,
};

Can remove 194 and 196 if that's the fix that is necessary.

Possible that they're unused individualized locations... might not even be worth programming in edge case handling to not merge them.

[Davil]

34 minutes ago, Kaphotics said:

So those two (well, 4) met locations are not legally obtainable?

internal static readonly HashSet<int> ValidMet_USUM = new HashSet<int>(ValidMet_SM)
{
    194, 196, 198,
    200, 202, 204, 206, 208, 210, 212, 214, 216, 218, 220, 222, 224, 226, 228, 230, 232,
};

Can remove 194 and 196 if that's the fix that is necessary.

Possible that they're unused individualized locations... might not even be worth programming in edge case handling to not merge them.

Those location IDs don't exist naturally in-game.

But,in PKHeX,as egg pokemon met location "Melemele (Akala)" is legal......

BUG?

[Kaphotics]

Fixed in the latest commit

https://github.com/kwsch/PKHeX/commit/f8bf3e400b036c7371b0ebbbba572caa405ad4fb