.PK1 Pokémon files aren't holding items when imported to Gen 2

[BeyondTheHorizon]

Not sure if this is a bug or if I'm doing something wrong, but I was messing around with importing .PK1 Pokémon files into my Crystal save when I noticed they weren't holding items. For example, Pidgeot is supposed to be holding a Bitter Berry when transferred to Gen 2, but when I imported my Pidgeot file it was holding nothing. I'm currently using PKHeX with the git commit 61b6519 (Allow box name editing on gen2), just so you know. Oh, and here's my .PK1 file too.

018 - PIDGEOT - A9DE.pk1

[Kaphotics]

Held item of that pkm has already been removed. Catch Rate in gen1 is stored at 0x7, which in that pk1's case, is 0.

Transferring over an untouched Pigeotto->Pigeot pk1 yields a Berry.

018 - PIDGEOT - E3D1.pk1

[BeyondTheHorizon]

I'm confused. I didn't go into my Crystal save and remove any item, and I don't understand what I did wrong to make its catch rate 0.

[Kaphotics]

Gen1 stores the pkm's catch rate when it is captured and is unused. Transferring to gen2 converts it to an item if necessary. If you remove the item, the value is 0.

You can't trade Gen1->Gen2->Gen1->Gen2 to constantly make items.

 

Probably was edited/modified prior. Loading a gen1 save with tradebacks disallowed shows your Pigeot as invalid (as the catch rate data needs to be valid, which isn't, because the held item was removed at some point).

[BeyondTheHorizon]

I tried both allowing and disallowing Gen 2 tradeback learnsets, and neither seem to work. It seems that the catch rate of Pokémon generated in PKHeX is currently automatically set to 0 though it says it's legal. I remember this didn't happen about a year ago when I was trying to figure out Time Capsule-related information and Pokémon imported to Gen 2 held items, so I'm leaning towards a bug here.

[Kaphotics]

Fixed, although somewhat unrelated:

https://github.com/kwsch/PKHeX/commit/14821dfb82ad6015417823f2491a0477535973e1

PKHeX gets the base species then enumerates the chain to see if any of the catch rates match. You'll have to temporarily set it as the original species from another unrelated chain:

Pigeot -> Mewtwo -> Pidgey -> Pigeot

0 -> 3 -> FF -> FF

 

I don't think it's a big enough need to have direct editing of the catch rate; may necessitate a new custom control (Auto checkbox, species selection, raw entry) which is a bit of effort for something so minor.

[BeyondTheHorizon]

Thanks for the effort, though it seems catch rates still aren't set when Gen 2 tradeback learnsets are allowed. When disallowed, catch rates are now set, though in the case of the Yellow Pikachu I found its catch rate is set to 190 instead of 163. Unfortunately, items still don't show when importing a Gen 1 Pokémon into a Gen 2 save file, probably for the above reason. Really sorry.

[BeyondTheHorizon]

Oops, screwed up badly. Pokémon DO hold items when imported from Gen 1 to Gen 2 while tradeback learnsets are disallowed. I only tested with the Yellow Pikachu, which I assume doesn't because its catch rate is set to 190 instead of 163. I'm an idiot!

Edited December 30, 2017 by BeyondTheHorizon
Corrected catch rate

[BeyondTheHorizon]

I can now definitely confirm that the Yellow Pikachu's catch rate is set to 190 instead of 163 when tradeback learnsets are disallowed unless one uses the Batch Editor. Is this intentional?

[Kaphotics]

It uses RB's table, as RB vs Y is not conclusively detectable from the raw data. There's no way to manually make a Yellow Pikachu unless you use the Batch Editor.

[BeyondTheHorizon]

Thanks for the info.