bug PKHeX always reports invalid checksum after scrolling PC box view

[ageispolis]

For any save file with valid checksums, PKHeX can be made to report an invalid checksum by viewing a different box in the "Box" tab. To reproduce:

1. Open any save file with valid checksums in PKHeX.
2. Go to the "SAV" tab and use "Verify Checksums" and/or "Block Data" to see that PKHeX calculates matching checksums upon opening the file.
3. Go to the "Box" tab and view a different box.
4. Repeat step 2 to find that PKHeX now reports problems such as "Large block checksum is invalid" for Gen 4 and "Invalid: 00 @ Region 0000 SAV: 73/74" for Gen 5. This happens even though the data is entirely unchanged to my understanding.

This occurs in ver 221218 for all games I tested from Gen 4, 5, 6 and 7. They are real cartridge save files that I dumped using Checkpoint. Of course, the games load all of these save files with no complaints.

This issue seems low-hanging, so I'm sorry if it's reported already or no one cares.

 

Edited January 15, 2023 by ageispolis
typo

[Kaphotics]

Switching boxes changes the "Current Box" value for the save file. After which, the save file is "modified", not un-tampered.

The program doesn't track every mutation to the save data to check if it was edited, so you should only really be checking immediately after opening the save file.

[ageispolis]

Got it, thanks.

Is this not one of the changes the program ought to track, knowing how easy it is to change it idly? Clearly I did not intuit that scrolling through the GUI would change the number in the save file as well.

Edited January 15, 2023 by ageispolis
never mind