L1nk2futr3 Posted March 28, 2022 Posted March 28, 2022 Tonight I was trying to modify the Hall of Fame data for my Y save file, but every time I made a change, the TID associated with the Pokemon being edited was changed to 00001. Trying to change it back manually doesn't work, it reverts back to this default number even after saving. I tried testing this with an Alpha Sapphire save and it did the same thing, so this might be an issue with gen 6?
Kaphotics Posted March 28, 2022 Posted March 28, 2022 Thanks, fixed on latest commit. https://github.com/kwsch/PKHeX/commit/4199a93be1cb4fb52de3ba540cee4d6251358c34 Can try the latest changes with the development build until the next release is stabilized. 1
L1nk2futr3 Posted April 23, 2022 Author Posted April 23, 2022 Hello again, I just tried to edit the same Hall of Fame entry in the latest version of the development build and it does the same thing. Am I doing something wrong or is the HOF editor still not working properly?
Kaphotics Posted April 23, 2022 Posted April 23, 2022 On 4/23/2022 at 4:41 AM, L1nk2futr3 said: Hello again, I just tried to edit the same Hall of Fame entry in the latest version of the development build and it does the same thing. Am I doing something wrong or is the HOF editor still not working properly? Expand Thanks for double checking, I missed one final thing... It was one of the oldest implemented code sections, so I figured it would be better to rewrite it -- should be fixed for good now. Thanks for reporting back!~ https://github.com/kwsch/PKHeX/commit/f5358e0e374f9cf903fe8dee8fd274dd72a23a83 1
L1nk2futr3 Posted April 24, 2022 Author Posted April 24, 2022 On 4/23/2022 at 5:43 PM, Kaphotics said: Thanks for double checking, I missed one final thing... It was one of the oldest implemented code sections, so I figured it would be better to rewrite it -- should be fixed for good now. Thanks for reporting back!~ https://github.com/kwsch/PKHeX/commit/f5358e0e374f9cf903fe8dee8fd274dd72a23a83 Expand No problem! I just tried to edit something again with the newest development build (evocriteria.1+64) and it has the same issue still. Is it still using some old code by any chance? If this helps, I also tried version +59 since it looked like the update was pushed in that version and it shows this error instead when trying to open the HoF editor. I tested other versions released in between this and the newest one and they don't show the error. Reveal hidden contents Exception Details: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. Parameter name: start at System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument) at PKHeX.Core.HallFame6Entity.get_OT_Name() at PKHeX.WinForms.SAV_HallOfFame.AddEntryDescription(List`1 s, HallFame6Entity entry) at PKHeX.WinForms.SAV_HallOfFame.AddEntries(Int32 offset, List`1 s, UInt32 year, UInt32 month, UInt32 day) at PKHeX.WinForms.SAV_HallOfFame.DisplayEntry(Object sender, EventArgs e) at System.Windows.Forms.ListBox.OnSelectedIndexChanged(EventArgs e) at System.Windows.Forms.ListBox.set_SelectedIndex(Int32 value) at PKHeX.WinForms.SAV_HallOfFame..ctor(SAV6 sav) at PKHeX.WinForms.Controls.SAVEditor.B_OUTHallofFame_Click(Object sender, EventArgs e) at System.Windows.Forms.Control.OnClick(EventArgs e) at System.Windows.Forms.Button.OnClick(EventArgs e) at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent) at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks) at System.Windows.Forms.Control.WndProc(Message& m) at System.Windows.Forms.ButtonBase.WndProc(Message& m) at System.Windows.Forms.Button.WndProc(Message& m) at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam) Loaded Assemblies: -------------------- mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 C:\Windows\Microsoft.NET\Framework64\v4.0.30319\mscorlib.dll PKHeX, Version=22.3.19.0, Culture=neutral, PublicKeyToken=null C:\Users\l1nk2\Downloads\PKHeX-framework\PKHeX.exe System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System\v4.0_4.0.0.0__b77a5c561934e089\System.dll System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Windows.Forms\v4.0_4.0.0.0__b77a5c561934e089\System.Windows.Forms.dll System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Drawing\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Drawing.dll System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Configuration\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Configuration.dll System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Core\v4.0_4.0.0.0__b77a5c561934e089\System.Core.dll System.Xml, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Xml\v4.0_4.0.0.0__b77a5c561934e089\System.Xml.dll PKHeX.Core, Version=22.3.19.0, Culture=neutral, PublicKeyToken=null C:\Users\l1nk2\Downloads\PKHeX-framework\PKHeX.Core.dll System.Memory, Version=4.0.1.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 C:\Users\l1nk2\Downloads\PKHeX-framework\System.Memory.dll System.Runtime, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Runtime\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Runtime.dll System.Runtime.CompilerServices.Unsafe, Version=4.0.4.1, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a C:\Users\l1nk2\Downloads\PKHeX-framework\System.Runtime.CompilerServices.Unsafe.dll System.Reflection, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Reflection\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Reflection.dll System.Runtime.InteropServices, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Runtime.InteropServices\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Runtime.InteropServices.dll System.Runtime.Extensions, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Runtime.Extensions\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Runtime.Extensions.dll Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed C:\Users\l1nk2\Downloads\PKHeX-framework\Newtonsoft.Json.dll PKHeX.Drawing.PokeSprite, Version=22.3.19.0, Culture=neutral, PublicKeyToken=null C:\Users\l1nk2\Downloads\PKHeX-framework\PKHeX.Drawing.PokeSprite.dll PKHeX.Drawing, Version=22.3.19.0, Culture=neutral, PublicKeyToken=null C:\Users\l1nk2\Downloads\PKHeX-framework\PKHeX.Drawing.dll System.ValueTuple, Version=4.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.ValueTuple\v4.0_4.0.0.0__cc7b13ffcd2ddd51\System.ValueTuple.dll PKHeX.Drawing.Misc, Version=22.3.19.0, Culture=neutral, PublicKeyToken=null C:\Users\l1nk2\Downloads\PKHeX-framework\PKHeX.Drawing.Misc.dll -------------------- User Message: An unhandled exception has occurred. You can continue running PKHeX, but please report this error.
Kaphotics Posted April 24, 2022 Posted April 24, 2022 On 4/24/2022 at 4:10 AM, L1nk2futr3 said: No problem! I just tried to edit something again with the newest development build (evocriteria.1+64) and it has the same issue still. Is it still using some old code by any chance? If this helps, I also tried version +59 since it looked like the update was pushed in that version and it shows this error instead when trying to open the HoF editor. I tested other versions released in between this and the newest one and they don't show the error. Expand Oops, silly mistake. Should be fixed for real now: https://github.com/kwsch/PKHeX/commit/1f49574be1d0f75ee37df932336707ce05e2510d I noticed the max name length was 1 character too short too, so that behaves correctly too now (nobody reporting that in 6 years) 1
L1nk2futr3 Posted April 24, 2022 Author Posted April 24, 2022 On 4/24/2022 at 5:07 AM, Kaphotics said: Oops, silly mistake. Should be fixed for real now: https://github.com/kwsch/PKHeX/commit/1f49574be1d0f75ee37df932336707ce05e2510d I noticed the max name length was 1 character too short too, so that behaves correctly too now (nobody reporting that in 6 years) Expand It works correctly now. Thanks for all your hard work! 1
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now