Poké Ball legality issues

[ashrobb]

I've been testing the Ball check feature and I've seen a few issues related to breeding and inheritance.

1. I think bred Pokémon are not being checked. For example, a Kalos bred Totodile can literally have any PokéBall besides Cherish and still pass the legality check, when in reality is limited to the ones listed in here http://www.serebii.net/games/geniiball.shtml since Gen 2 starters can be captured on Pokémon Colosseum. However it passes the Apricorn Balls (non existant in Gen III and it can't be captured on Gen IV), the Safari Ball, etc. This also allows a Gen V or VI bred Pokémon to pass as legal when it has an Apricorn Ball, when these were exclusive to Gen IV games.(*)

2. Bred male only species: Gen VI Ball inheritance mechanics doesn't allow male Pokémon and Ditto to pass its captured PokéBall down. So Tauros, the Hitmons and Rufflet/Braviary should have this checked, as they only can be in a Poké Ball when bred. Other male species can actually bred from alternate female evolutions as Gardevoir or Nidoking (Nidoran female, Nidorina, Nidoqueen). http://bulbapedia.bulbagarden.net/wiki/List_of_Pokémon_by_gender_ratio#Male_only

3. Same thing with Genderless Pokémon. If bred, they can only be in PokéBalls. They pass as legal in PKHeX with any ball besides Cherish (tested with KB Rotom).

4. The Master Ball. This is always checked as legal in bred Pokémon regardless of the Generation (tested with a baby Tyrunt and Chespin I just bred). This is illegal, period, since Master and Cherish balls don't pass through breeding in any condition. Master Ball is only for caught Pokémon and Cherish for events.

Useful links

http://www.serebii.net/games/pokeball.shtml

http://bulbapedia.bulbagarden.net/wiki/Pokémon_breeding#Inheriting_Pok.C3.A9_Balls

---

(*) Now, I know some of this paragraph specially may be something minor since the Ray Rizzo incident with the Dream Ball Aegislash, where the Pokémon was legal/legit because it was bred ingame, even when it came from hacked parents/the ball was edited. It was even allowed to participate in an official tournament back then, but XY were fairly new and these kind of checks may not been implemented. I dunno if this should be a warning more than an illegal flag, but it's your call. And this also can be difficult to code into the app since the check has to be individual? The others seem more feasible to check.

[Kaphotics]

Implemented 2,3,4; 1 isn't a simple solution as we know

Thanks for the report, I'll have to think about #1 for a bit. PKHeX currently catches Kalos pkm with dream balls (sans Sylveon), and 5th/6th gen pkm with Safari Balls. For the other unimplemented exclusions, yeah, fun.