Well, I was working on my own PID/IVs tool, and found out some issues. In order to reproduce them, you can get a Pal Parked Pikachu and a Shinx off pkmndb.com, and then change their PID and IVs each time with the following values (an initial seed of 0x0 was used):
Pokemon ID: 59774 - Quirky, Female, Ability 1, Not Shiny
Date: marzo 25, 2009
IVs: 17,19,20,16,13,12
Trainer ID: 27042
Secret ID: 59019
Trainer Gender: Female
Hidden Power: Rock - 31
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Sinnoh [Platinum]
Country Originated: UK/US/AU
Type: Common GBA Event [Restricted]
--------------------
Even if Pikachu passed all checks, it is not a GBA event, so it shouldn't appear like that. As for Shinx... well, it cannot be a GBA event, obviously.
Did I miss some GBA methods? Also, regarding the GBA Event, Restricted vs. Unrestricted... how would the Legality Checker know the right one? As far as I know, the difference between the two is that Restricted's seed is limited to 16 bits rather than 32 bits, thus ranging from 0x0 to 0xFFFF. However, the same range could also fall in a Unrestricted type, even if there are pretty low probabilities. According to my tests, the program will just consider anything higher than 0xFFFF as Unrestricted. I would have gladly checked myself, but there's no source code publicy available (and the binary file it's obfuscated too).
Legality Checker vB54-24
in Legality Checker
Posted
Well, I was working on my own PID/IVs tool, and found out some issues. In order to reproduce them, you can get a Pal Parked Pikachu and a Shinx off pkmndb.com, and then change their PID and IVs each time with the following values (an initial seed of 0x0 was used):
Legality Checker output:
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\pikachu.pkm
Checksum: 0x69BF - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: ottobre 08, 2008
IVs: 17,19,20,16,13,12
Trainer ID: 22186
Secret ID: 25086
Trainer Gender: Female
Hidden Power: Rock - 31
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Kanto [Leaf Green]
Country Originated: UK/US/AU
PalPark Country: UK/US/AU
Trash Bytes: Valid
Type: Uncommon GBA (A-C-D-E)
Type: Common GBA (A-B-C-D)
--------------------
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\shinx.pkm
Checksum: 0x7DB0 - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: marzo 25, 2009
IVs: 17,19,20,16,13,12
Trainer ID: 27042
Secret ID: 59019
Trainer Gender: Female
Hidden Power: Rock - 31
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Sinnoh [Platinum]
Country Originated: UK/US/AU
Type: Common NDS (A-B-C-D) - Sync: Valid
--------------------
While Shinx looks fine, Pikachu got 2 types, which is indeed misleading. The right type is actually the second one, anyway.
Legality Checker output:
File: D:\Desktop\pikachu.pkm
Checksum: 0x5808 - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: ottobre 08, 2008
IVs: 17,19,20,2,18,3
Trainer ID: 22186
Secret ID: 25086
Trainer Gender: Female
Hidden Power: Fire - 66
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Kanto [Leaf Green]
Country Originated: UK/US/AU
PalPark Country: UK/US/AU
Trash Bytes: Valid
Type: Never seen this. A-C-D-F
Type: Uncommon GBA (A-B-C-E)
--------------------
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\shinx.pkm
Checksum: 0x6BF9 - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: marzo 25, 2009
IVs: 17,19,20,2,18,3
Trainer ID: 27042
Secret ID: 59019
Trainer Gender: Female
Hidden Power: Fire - 66
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Sinnoh [Platinum]
Country Originated: UK/US/AU
Type: Hacked or Unknown Pokemon
--------------------
Once again, Pikachu has 2 types. The second one is the good one. Shinx, as expected, appears as hacked/unknown.
Legality Checker output:
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\pikachu.pkm
Checksum: 0x824D - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: ottobre 08, 2008
IVs: 17,19,20,12,22,24
Trainer ID: 22186
Secret ID: 25086
Trainer Gender: Female
Hidden Power: Fighting - 41
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Kanto [Leaf Green]
Country Originated: UK/US/AU
PalPark Country: UK/US/AU
Trash Bytes: Valid
Type: Ultra Rare GBA (A-B-C-F)
--------------------
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\shinx.pkm
Checksum: 0x963E - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: marzo 25, 2009
IVs: 17,19,20,12,22,24
Trainer ID: 27042
Secret ID: 59019
Trainer Gender: Female
Hidden Power: Fighting - 41
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Sinnoh [Platinum]
Country Originated: UK/US/AU
Type: Hacked or Unknown Pokemon
--------------------
Nothing much to say here, everything looks okay.
Legality Checker output:
File: D:\Desktop\pikachu.pkm
Checksum: 0x3747 - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: ottobre 08, 2008
IVs: 16,13,12,2,18,3
Trainer ID: 22186
Secret ID: 25086
Trainer Gender: Female
Hidden Power: Fire - 65
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Kanto [Leaf Green]
Country Originated: UK/US/AU
PalPark Country: UK/US/AU
Trash Bytes: Valid
Type: Never seen this. A-C-E-F
Type: Uncommon GBA (A-B-D-E)
--------------------
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\shinx.pkm
Checksum: 0x4B38 - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: marzo 25, 2009
IVs: 16,13,12,2,18,3
Trainer ID: 27042
Secret ID: 59019
Trainer Gender: Female
Hidden Power: Fire - 65
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Sinnoh [Platinum]
Country Originated: UK/US/AU
Type: Hacked or Unknown Pokemon
--------------------
Once again, Pikachu has two types, the 2nd one being the actual one. Shinx looks okay.
Legality Checker output:
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\pikachu.pkm
Checksum: 0x618C - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: ottobre 08, 2008
IVs: 16,13,12,12,22,24
Trainer ID: 22186
Secret ID: 25086
Trainer Gender: Female
Hidden Power: Fighting - 40
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Kanto [Leaf Green]
Country Originated: UK/US/AU
PalPark Country: UK/US/AU
Trash Bytes: Valid
Type: Rare GBA (A-B-D-F)
--------------------
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\shinx.pkm
Checksum: 0x757D - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: marzo 25, 2009
IVs: 16,13,12,12,22,24
Trainer ID: 27042
Secret ID: 59019
Trainer Gender: Female
Hidden Power: Fighting - 40
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Sinnoh [Platinum]
Country Originated: UK/US/AU
Type: Hacked or Unknown Pokemon
--------------------
Everything's okay this time.
Legality Checker output:
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\pikachu.pkm
Checksum: 0x3E1E - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: ottobre 08, 2008
IVs: 2,18,3,12,22,24
Trainer ID: 22186
Secret ID: 25086
Trainer Gender: Female
Hidden Power: Fighting - 44
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Kanto [Leaf Green]
Country Originated: UK/US/AU
PalPark Country: UK/US/AU
Trash Bytes: Valid
Type: Very Rare GBA (A-B-E-F)
--------------------
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\shinx.pkm
Checksum: 0x520F - Valid
Pokemon ID: 3917348864 - Naive, Female, Ability 1, Not Shiny
Date: marzo 25, 2009
IVs: 2,18,3,12,22,24
Trainer ID: 27042
Secret ID: 59019
Trainer Gender: Female
Hidden Power: Fighting - 44
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Sinnoh [Platinum]
Country Originated: UK/US/AU
Type: Hacked or Unknown Pokemon
--------------------
Pikachu and Shinx appear just as expected.
Legality Checker output:
File: D:\Desktop\pikachu.pkm
Checksum: 0x3747 - Valid
Pokemon ID: 1383137280 - Bold, Female, Ability 1, Not Shiny
Date: ottobre 08, 2008
IVs: 16,13,12,2,18,3
Trainer ID: 22186
Secret ID: 25086
Trainer Gender: Female
Hidden Power: Fire - 65
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Kanto [Leaf Green]
Country Originated: UK/US/AU
PalPark Country: UK/US/AU
Trash Bytes: Valid
Type: Never seen this. A-D-E-F
Type: Uncommon GBA (A-C-D-E)
--------------------
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\shinx.pkm
Checksum: 0x4B38 - Valid
Pokemon ID: 1383137280 - Bold, Female, Ability 1, Not Shiny
Date: marzo 25, 2009
IVs: 16,13,12,2,18,3
Trainer ID: 27042
Secret ID: 59019
Trainer Gender: Female
Hidden Power: Fire - 65
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Sinnoh [Platinum]
Country Originated: UK/US/AU
Type: Hacked or Unknown Pokemon
--------------------
Pikachu = 2 types, Shinx = okay.
Legality Checker output:
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\pikachu.pkm
Checksum: 0x618C - Valid
Pokemon ID: 1383137280 - Bold, Female, Ability 1, Not Shiny
Date: ottobre 08, 2008
IVs: 16,13,12,12,22,24
Trainer ID: 22186
Secret ID: 25086
Trainer Gender: Female
Hidden Power: Fighting - 40
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Kanto [Leaf Green]
Country Originated: UK/US/AU
PalPark Country: UK/US/AU
Trash Bytes: Valid
Type: Never seen this. A-C-D-F
--------------------
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\shinx.pkm
Checksum: 0x757D - Valid
Pokemon ID: 1383137280 - Bold, Female, Ability 1, Not Shiny
Date: marzo 25, 2009
IVs: 16,13,12,12,22,24
Trainer ID: 27042
Secret ID: 59019
Trainer Gender: Female
Hidden Power: Fighting - 40
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Sinnoh [Platinum]
Country Originated: UK/US/AU
Type: Hacked or Unknown Pokemon
--------------------
Pikachu = okay, Shiny = okay.
Legality Checker output:
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\pikachu.pkm
Checksum: 0x3E1E - Valid
Pokemon ID: 833617920 - Calm, Female, Ability 1, Not Shiny
Date: ottobre 08, 2008
IVs: 2,18,3,12,22,24
Trainer ID: 22186
Secret ID: 25086
Trainer Gender: Female
Hidden Power: Fighting - 44
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Kanto [Leaf Green]
Country Originated: UK/US/AU
PalPark Country: UK/US/AU
Trash Bytes: Valid
Type: Never seen this. A-D-E-F
--------------------
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\shinx.pkm
Checksum: 0x520F - Valid
Pokemon ID: 833617920 - Calm, Female, Ability 1, Not Shiny
Date: marzo 25, 2009
IVs: 2,18,3,12,22,24
Trainer ID: 27042
Secret ID: 59019
Trainer Gender: Female
Hidden Power: Fighting - 44
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Sinnoh [Platinum]
Country Originated: UK/US/AU
Type: Hacked or Unknown Pokemon
--------------------
Pikachu = okay, Shinx = okay.
Legality Checker output:
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\pikachu.pkm
Checksum: 0x69BF - Valid
Pokemon ID: 59774 - Quirky, Female, Ability 1, Not Shiny
Date: ottobre 08, 2008
IVs: 17,19,20,16,13,12
Trainer ID: 22186
Secret ID: 25086
Trainer Gender: Female
Hidden Power: Rock - 31
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Kanto [Leaf Green]
Country Originated: UK/US/AU
PalPark Country: UK/US/AU
Trash Bytes: Valid
Type: Common GBA Event [Restricted]
--------------------
Pokemon Legality Checker - by: Sabresite - vB54-24
File: D:\Desktop\shinx.pkm
Checksum: 0x7DB0 - Valid
Pokemon ID: 59774 - Quirky, Female, Ability 1, Not Shiny
Date: marzo 25, 2009
IVs: 17,19,20,16,13,12
Trainer ID: 27042
Secret ID: 59019
Trainer Gender: Female
Hidden Power: Rock - 31
Fateful Encounter: No
Gender Check: Valid
Effort Values: Valid
Nicknamed: No
Home Town: Sinnoh [Platinum]
Country Originated: UK/US/AU
Type: Common GBA Event [Restricted]
--------------------
Even if Pikachu passed all checks, it is not a GBA event, so it shouldn't appear like that. As for Shinx... well, it cannot be a GBA event, obviously.
Did I miss some GBA methods? Also, regarding the GBA Event, Restricted vs. Unrestricted... how would the Legality Checker know the right one? As far as I know, the difference between the two is that Restricted's seed is limited to 16 bits rather than 32 bits, thus ranging from 0x0 to 0xFFFF. However, the same range could also fall in a Unrestricted type, even if there are pretty low probabilities. According to my tests, the program will just consider anything higher than 0xFFFF as Unrestricted. I would have gladly checked myself, but there's no source code publicy available (and the binary file it's obfuscated too).