I'm just going to post my case here for some additional info.
Moon = Banned - genned mons [legal], max items [all types], pokemon dex complete, max money, edited trainer location and pokefinder.
Sun = not banned - genned Mons [legal], 999x all medicine and item slot items and max money.
It seems Pokedex is the main culprit here.
My friends who have genned mons from me or themselves are not banned either.
The bans are save/game sync only and only restrict you from playing in battle spot, rating battles and global missions.
As far as I know the pkhex rules state that you shouldn't be playing battlespot etc with genned mons anyway, so this ban barely matters.
I think I deserve the ban but hey it was for science, I wanted to check if getting the shiny charm through the achievement of filling the pokedex was different from just adding it in.
My reason to believe that they got caught was probably making a tapu or any other shiny locked pokemon shiny and unlocking the dex entry.
Like I mentioned earlier only my save with full pokedex got banned. for example I edited my sun/moon demo greninja to be shiny on sun and it didn't get banned.