Bugs with GenIV save editor

[Hawkinslone]

When I move(Party to Box / Box to Party) or delete pokemon from the party there is a problem: deleted/moved pokemon appears in party again and replace another one and this one disappear. 

[Kaphotics]

Thanks for reporting; I found that there's other issues with deleting a party slot for other versions too. Fixed in latest commits, so you'll have to wait for the next release.

https://github.com/kwsch/PKHeX/commit/3b0fd81aae4a49a171b438846e09cc5d6a53eddc

In the meantime, swap to occupied slots only. Clone things as placeholder if need be

[paf]

another bug in pkhex is when transfering a pokemon with an item from gen 4 to 5 the item is going  to gen 5 as well.

[Kaphotics]

7 minutes ago, paf said:

another bug in pkhex is when transfering a pokemon with an item from gen 4 to 5 the item is going  to gen 5 as well.

That's a user-experience benefit (my choice); to retain if possible.

if (!Legal.HeldItems_BW.Contains((ushort)HeldItem))
{
    pk5.HeldItem = 0; // if valid, it's already copied
}

Will only delete the item if it's not a valid held item in Gen5.

 

Would you want me to delete if it is not released? I don't like mixing in legality to the central pkm logic...