Jump to content

3 gen error: Ruby sav opened as Emerald


Dr.Matt
 Share

Recommended Posts

I don't know why, but PKHex fails detecting the file version for some of my Ruby saves (from original spanish cartridge, 100% no cheats). I've been using Collosseum, XD and Pokémon Channel all these years with that game, maybe that's the reason... Maybe some data changed!?

I suggest implementing a manual version selector for RSE, if it's possible. I think that would fix the problem.
The save works fine with Trigger's PC (has version selector), but in PKHex I had problems with the trainer data and that stuff that are different in Emerald.

Thank you.

 

BTW: Great job, best editor ever!!

 

Link to comment
Share on other sites

Manual selection is already implemented; hold control when importing to bring up the selection.

Version detection isn't perfect for Gen3; PKHeX uses Bulbapedia's detection method which isn't correct.

https://bulbapedia.bulbagarden.net/wiki/Save_data_structure_in_Generation_III#Game_Code

https://github.com/kwsch/PKHeX/blob/668b8611d51e0e0b28240508026b4c0ae1f1ce33/PKHeX.Core/Saves/Util/SaveUtil.cs#L230-L249

The ROM disassembly indicates that this offset isn't game code:

https://github.com/pret/pokeruby/blob/51ecf10029f84dd5423cd59582d01eaee9140c0e/include/global.h#L822-L844

In the future it'd be nice to have a more foolproof detection, but for now, just override if it's incorrectly detected.

 

(edit: future versions of pkhex will have improved detection logic for RS<->E differentiation)

  • Like 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

×
×
  • Create New...